Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): Speed up LLD by reducing the post-success raise. #17102

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

ryanthecoder
Copy link
Contributor

Overview

Right now if we successfully detect liquid we raise (slowly) the entire max pass distance. this takes a while, especially on the 96 channel since it's calculated off the max plunger speed.
This reduces the post-success raise to the "safe plunger prep" distance which we know is a safe distance from the liquid to prevent unwanted capillary action or adhesion to the outside of the tip.

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

@ryanthecoder ryanthecoder requested a review from a team as a code owner December 13, 2024 15:26
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should do this because if the probe failed to trigger for whatever reason this would make the situation much worse by doing an uncommanded aspiration.

Can we instead speed up the retract so it's not super slow?

@ryanthecoder
Copy link
Contributor Author

This doesn't move the plunger it just moves the Z up. And this move only happens when there is a successful detection

@sfoster1
Copy link
Member

This doesn't move the plunger it just moves the Z up. And this move only happens when there is a successful detection

right, but presumably the next thing that happens is a plunger prep, since otherwise we wouldn't have to do it at all, right? and a successful detection doesn't necessarily mean it was a successful detection right at the meniscus. I know we tested the hell out of this, but if we're designing for robustness here then we can avoid unforeseen problems.

@ryanthecoder
Copy link
Contributor Author

The next move is actually another Z move to the top of the well + the safe plunger distance, before the plunger prep, so the observed behavior is that it taps the liquid, raises way out of the well, moves back to the top of the well and then does plunger prep

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, this looks good then. But why do this move at all? Just to be slower to avoid external droplets?

@ryanthecoder
Copy link
Contributor Author

Okay, this looks good then. But why do this move at all? Just to be slower to avoid external droplets?

Yea we saw extra external droplets if we stay touching the meniscus too long, and ethanol has a nasty habit of starting to capillary action up into the tip very quickly after the plunger stops dispensing.

@ryanthecoder ryanthecoder merged commit 352e4ac into edge Dec 13, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants