Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol-designer,app): use dynamic import for react-scan to avoid build issue #17087

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

koji
Copy link
Contributor

@koji koji commented Dec 11, 2024

Overview

use dynamic import for react-scan to avoid build issue

x Build failed in 5.79s
error during build:
src/App/DesktopApp.tsx (1:9): "scan" is not exported by "../node_modules/react-scan/dist/rsc-shim.mjs", imported by "src/App/DesktopApp.tsx".
file: /Users/koji/Desktop/dev_test/opentrons/app/src/App/DesktopApp.tsx:1:9

1: import { scan } from 'react-scan'
            ^
2: import { useState, Fragment } from 'react'
3: import { Navigate, Route, Routes, useMatch } from 'react-router-dom'

Test Plan and Hands on Testing

make -C protocol-designer build -> no error
make -C app dist -> no error

Changelog

Review requests

Risk assessment

low

…d build issue

use dynamic import for react-scan to avoid build issue
@koji koji marked this pull request as ready for review December 11, 2024 17:42
@koji koji requested review from a team as code owners December 11, 2024 17:42
@koji koji removed the request for review from a team December 11, 2024 17:42
Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great timing, just ran into this myself 😁 Thank you!

@koji
Copy link
Contributor Author

koji commented Dec 11, 2024

Great timing, just ran into this myself 😁 Thank you!

i was about to post about reviewing this.
thank you for your quick review!

@koji koji merged commit 96fc13e into edge Dec 11, 2024
44 checks passed
@koji koji deleted the fix_build-option-for-react-scan branch December 11, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants