Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(robot-server): Implement the /labwareOffsets endpoints with an in-memory store #17059

Merged
merged 5 commits into from
Dec 6, 2024

Conversation

SyntaxColoring
Copy link
Contributor

@SyntaxColoring SyntaxColoring commented Dec 6, 2024

Overview

This adds a temporary implementation of the /labwareOffsets endpoints so that we have something to play with and test the client against. Closes EXEC-1012.

Limitations:

  • Does not persist across reboots yet (that's EXEC-1015)
  • No pagination yet (that's just a bit of a mess right now; I'm working on it)

Test Plan and Hands on Testing

We should be covered by automated tests added in this PR.

Review requests

  • Do the implemented semantics look right?
  • Anything else we want the tests to cover?

Risk assessment

No risk. All new and nothing uses this yet.

@SyntaxColoring SyntaxColoring requested review from TamarZanzouri, mjhuff and a team December 6, 2024 19:53
@SyntaxColoring SyntaxColoring requested review from a team as code owners December 6, 2024 19:53
Copy link
Contributor

@TamarZanzouri TamarZanzouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! logic looks correct to me as well as testing

@SyntaxColoring SyntaxColoring merged commit 5405714 into edge Dec 6, 2024
7 checks passed
@SyntaxColoring SyntaxColoring deleted the labware_offset_in_memory_store branch December 6, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants