Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(api): install opentrons and simulate #17048

Merged
merged 17 commits into from
Dec 16, 2024
Merged

test(api): install opentrons and simulate #17048

merged 17 commits into from
Dec 16, 2024

Conversation

y3rsh
Copy link
Member

@y3rsh y3rsh commented Dec 5, 2024 •
edited
Loading

Overview

Here is a basic framework and some tests.
Let me know what you think.

@y3rsh y3rsh self-assigned this Dec 5, 2024
@y3rsh y3rsh marked this pull request as ready for review December 6, 2024 16:25
@y3rsh y3rsh requested a review from a team as a code owner December 6, 2024 16:25
SyntaxColoring
SyntaxColoring approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@SyntaxColoring SyntaxColoring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you!

.github/workflows/api-test-lint-deploy.yaml Outdated Show resolved Hide resolved
.github/workflows/api-test-lint-deploy.yaml Outdated Show resolved Hide resolved
sfoster1
sfoster1 requested changes Dec 6, 2024
View reviewed changes
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We really need to test this on windows, perhaps most of all, unfortunately. Might need to have a powershell equivalent. Sorry to say it!

.github/workflows/api-test-lint-deploy.yaml Outdated Show resolved Hide resolved
package-testing/Makefile Outdated Show resolved Hide resolved
package-testing/Makefile Outdated Show resolved Hide resolved
package-testing/Makefile Outdated Show resolved Hide resolved
@y3rsh y3rsh requested a review from a team as a code owner December 7, 2024 13:26
sfoster1
sfoster1 approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, thank yoU!

@y3rsh y3rsh merged commit 0540c01 into edge Dec 16, 2024
14 checks passed
@y3rsh y3rsh deleted the RQA-3766-test branch December 16, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SyntaxColoring SyntaxColoring SyntaxColoring approved these changes

@sfoster1 sfoster1 sfoster1 approved these changes

Assignees

@y3rsh y3rsh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@y3rsh @sfoster1 @SyntaxColoring