Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): peek pipette bug fixes #16985

Merged
merged 3 commits into from
Nov 26, 2024
Merged

fix(api): peek pipette bug fixes #16985

merged 3 commits into from
Nov 26, 2024

Conversation

caila-marashaj
Copy link
Contributor

@caila-marashaj caila-marashaj commented Nov 26, 2024

Overview

On testing the peek pipette on a robot, there are two bugs:

  • The peek pipette was getting loaded by serial number correctly as an em_pipette, but the shared-data file getting loaded in was that of the regular 8 channel pipettes
  • The custom default_max_speed was getting overwritten by ot3api::set_system_constraints_for_plunger_acceleration

This pr contains fixes for both of these that have been tested on the robot.

Changelog

  • remove update_constraints_for_emulsifying_pipette, instead just place a check for the high speed pipettes inside set_system_constraints_for_plunger_acceleration
  • add necessary EIGHT_CHANNEL_EM types so the correct shared-data file gets loaded in

Test Plan

  • Load a peek pipette onto the robot using cache_instruments
  • Aspirate, make sure the speed on the move request on the CAN bus, after conversion, is 90 mm/sec
  • Dispense make sure the speed on the move request on the CAN bus, after conversion, is 90 mm/sec
  • During both of these, make sure there are no bind_sensor_output_requests directed to the peek pipette

@caila-marashaj caila-marashaj requested a review from a team as a code owner November 26, 2024 21:25
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but let's change the name of the param

@caila-marashaj caila-marashaj merged commit ab58237 into edge Nov 26, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants