Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(openrons-ai-server, opentrons-ai-client): predict method #16967

Merged
merged 2 commits into from
Nov 25, 2024
Merged

fix(openrons-ai-server, opentrons-ai-client): predict method #16967

merged 2 commits into from
Nov 25, 2024

Conversation

Elyorcv
Copy link
Contributor

@Elyorcv Elyorcv commented Nov 25, 2024 •
edited
Loading

Overview

Two changed

  • Backend: Previously, two endpoints end up using the same model, therefore confused during message processing. Present, two endpoints use separate models.
  • Frontend: Flex gripper is concerned with only Flex robot
    • opentrons-ai-client/src/resources/utils/createProtocolUtils.tsx

Closes AUTH-1076

Test Plan and Hands on Testing

  • Visit opentrons.ai
  • Click Update an existing protocol and follow instructions
  • Click Create a new protocol and follow instructions. Once you complete providing labware and other information. Click Submit then it will take you chat window where you need to see the generated protocol. It should not start like 'Simulation is successful'.

Changelog

Review requests

All tests are passing

Risk assessment

Low

@Elyorcv Elyorcv force-pushed the AUTH-1076-slas-2025-assign-separate-model-instances-for-create-and-update-endpoints branch 3 times, most recently from ad67463 to 81156e9 Compare November 25, 2024 09:52
@Elyorcv Elyorcv marked this pull request as ready for review November 25, 2024 10:14
@Elyorcv Elyorcv requested review from a team as code owners November 25, 2024 10:14
@Elyorcv Elyorcv requested review from y3rsh and jbleon95 November 25, 2024 10:26
y3rsh
y3rsh requested changes Nov 25, 2024
View reviewed changes
Copy link
Member

@y3rsh y3rsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. The only item requiring change is the None check on the history. All the rest are nits.

opentrons-ai-server/api/domain/anthropic_predict.py Outdated Show resolved Hide resolved
opentrons-ai-server/api/handler/fast.py Outdated Show resolved Hide resolved
opentrons-ai-server/api/models/chat_request.py Outdated Show resolved Hide resolved
opentrons-ai-server/api/models/chat_request.py Outdated Show resolved Hide resolved
@Elyorcv
fix(openrons-ai-server, opentrons-ai-client): predict method is divid…
d863da5 
…ed into create and update

Previously, users end up with the same chatcompletion endpoint no matter which method it is used
@Elyorcv
Fixed None check for chathistory, and typo, and modified standard loa…
3f8aa4f 
…dnames [AUTH-1076]
@Elyorcv Elyorcv force-pushed the AUTH-1076-slas-2025-assign-separate-model-instances-for-create-and-update-endpoints branch from e7650f1 to 3f8aa4f Compare November 25, 2024 15:06
y3rsh
y3rsh approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@y3rsh y3rsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Elyorcv Elyorcv merged commit 378a1f2 into edge Nov 25, 2024
10 checks passed
@Elyorcv Elyorcv deleted the AUTH-1076-slas-2025-assign-separate-model-instances-for-create-and-update-endpoints branch November 25, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y3rsh y3rsh y3rsh approved these changes

@jbleon95 jbleon95 Awaiting requested review from jbleon95

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Elyorcv @y3rsh