fix(api): ungrip gripper should home g #16933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TamarZanzouri
requested review from
shlokamin
and removed request for
a team
TamarZanzouri
requested review from
sfoster1,
SyntaxColoring and
mjhuff
and removed request for
shlokamin
|
For context, the reason we're doing this instead of the previous approach (home g), is because the door needs to be open while we home g, which should be handled by the |
mjhuff
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
closes https://opentrons.atlassian.net/browse/RQA-3645.
unsafe/ungripshould call home G instead of ungrip.revert #16928
Test Plan and Hands on Testing
as explained in the ticket + door open/close should work.
Changelog
make ungrip command call hardware api home G instead of ungrip
Risk assessment
low.