Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(api): Opentrons Tough PCR Auto-sealing Lids in Python API #16925

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

ecormany
Copy link
Contributor

Overview

Documents how to use the Opentrons Tough PCR Auto-sealing Lids and Opentrons Flex Deck Riser in a Python protocol.

Test Plan and Hands on Testing

  • Sandbox
  • all new code samples pass simulation

Changelog

  • New section on auto-sealing lids
  • Change load statement at top of article to use Opentrons PCR plate instead of NEST

Review requests

  • Completeness, clarity, etc.
  • Double-check code
  • There is some deliberate vagueness around lid loading that is meant to future-proof against labware schema and API changes

Risk assessment

none, docs.

@ecormany ecormany requested a review from a team as a code owner November 20, 2024 23:11
@ecormany ecormany added docs papi-v2 Python API V2 labels Nov 20, 2024
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.43%. Comparing base (ec7641c) to head (86108b2).
Report is 227 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #16925   +/-   ##
=======================================
  Coverage   92.43%   92.43%           
=======================================
  Files          77       77           
  Lines        1283     1283           
=======================================
  Hits         1186     1186           
  Misses         97       97           
Flag Coverage Δ
g-code-testing 92.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

Copy link
Contributor

@jwwojak jwwojak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice text. Thorough and concise.

:shipit: IMO

Copy link
Collaborator

@emilyburghardt emilyburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

Copy link
Contributor

@CaseyBatten CaseyBatten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, everything here is accurate to the current operation and use of the auto sealing lids.

Of note for the future, we will need to revisit this with some API related exception cases for future releases that introduce lid specialization.

@ecormany ecormany merged commit ecd916b into edge Nov 21, 2024
30 checks passed
@ecormany ecormany deleted the docs-tc-lids branch November 21, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs papi-v2 Python API V2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants