app(fix): Fix error recovery on desktop DQA #16916
Merged
+42
−57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
As with the previous DQA tickets, the proof is linked in each ticket. There are two important fixes, the first two commits.
Commit 1 - RQA-3632 Step number doesn't translate 1-1 to 0 based indexing :)
Commit 2 - RQA-3642 The "meaty" one. QA hasn't seen alpha.3, so they haven't reported it yet, but there are times we accidentally show a generic "error" recovery modal after cancelling the run, and that's because we now gate recovery behind there being a failed command OR there being a stop requested run status. The problem is these data are derived from separate HTTP resources, so there can be torn state, in which we get the flicker behavior shown in the ticket video. The solution is just to reduce the complexity of the hook. We don't need intermediate state,
hasSeenAwaitingRecovery
, as this creates an extra render cycle that leads to the flickering.Commit 3 - RQA-3629
Commit 4 - RQA-3627
Test Plan and Hands on Testing
Risk assessment
low