Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(shared-data): rename emulsify to em #16911

Merged
merged 2 commits into from
Nov 20, 2024
Merged

chore(shared-data): rename emulsify to em #16911

merged 2 commits into from
Nov 20, 2024

Conversation

ryanthecoder
Copy link
Contributor

Overview

In order to simplify and make future planning for how to display this OEM rename emulsify to EM everywhere for the new 8 channel

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

@ryanthecoder ryanthecoder requested review from a team as code owners November 20, 2024 17:24
@ryanthecoder ryanthecoder requested review from jerader and removed request for a team November 20, 2024 17:24
sfoster1
sfoster1 approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

em it is!

@codecov Codecov
Copy link

codecov bot commented Nov 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.17%. Comparing base (db8b1e5) to head (7421e9e).
Report is 2 commits behind head on edge.

Files with missing lines Patch % Lines
.../python/opentrons_shared_data/pipette/dev_types.py 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #16911      +/-   ##
==========================================
- Coverage   80.75%   79.17%   -1.59%     
==========================================
  Files         107      120      +13     
  Lines        4001     4513     +512     
==========================================
+ Hits         3231     3573     +342     
- Misses        770      940     +170
Flag Coverage Δ
g-code-testing 92.43% <ø> (ø)
shared-data 73.90% <50.00%> (-1.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../python/opentrons_shared_data/pipette/load_data.py 87.93% <ø> (ø)
...data/pipette/scripts/update_configuration_files.py 0.00% <ø> (ø)
...data/python/opentrons_shared_data/pipette/types.py 95.69% <100.00%> (ø)
.../python/opentrons_shared_data/pipette/dev_types.py 0.00% <0.00%> (ø)

... and 13 files with indirect coverage changes

---- 🚨 Try these New Features:

@ryanthecoder ryanthecoder merged commit 3839366 into edge Nov 20, 2024
49 of 50 checks passed
ryanthecoder added a commit that referenced this pull request Nov 23, 2024
@ryanthecoder
chore(shared-data): rename emulsify to em (#16911)
151e361 
<!--
Thanks for taking the time to open a Pull Request (PR)! Please make sure
you've read the "Opening Pull Requests" section of our Contributing
Guide:

https://github.com/Opentrons/opentrons/blob/edge/CONTRIBUTING.md#opening-pull-requests

GitHub provides robust markdown to format your PR. Links, diagrams,
pictures, and videos along with text formatting make it possible to
create a rich and informative PR. For more information on GitHub
markdown, see:

https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax

To ensure your code is reviewed quickly and thoroughly, please fill out
the sections below to the best of your ability!
-->

In order to simplify and make future planning for how to display this
OEM rename emulsify to EM everywhere for the new 8 channel
<!--
Describe your PR at a high level. State acceptance criteria and how this
PR fits into other work. Link issues, PRs, and other relevant resources.
-->

<!--
Describe your testing of the PR. Emphasize testing not reflected in the
code. Attach protocols, logs, screenshots and any other assets that
support your testing.
-->

<!--
List changes introduced by this PR considering future developers and the
end user. Give careful thought and clear documentation to breaking
changes.
-->

<!--
- What do you need from reviewers to feel confident this PR is ready to
merge?
- Ask questions.
-->

<!--
- Indicate the level of attention this PR needs.
- Provide context to guide reviewers.
- Discuss trade-offs, coupling, and side effects.
- Look for the possibility, even if you think it's small, that your
change may affect some other part of the system.
- For instance, changing return tip behavior may also change the
behavior of labware calibration.
- How do your unit tests and on hands on testing mitigate this PR's
risks and the risk of future regressions?
- Especially in high risk PRs, explain how you know your testing is
enough.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfoster1 sfoster1 sfoster1 approved these changes

@jerader jerader Awaiting requested review from jerader jerader is a code owner automatically assigned from Opentrons/js

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanthecoder @sfoster1