Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hardware-testing): flex stacker diagnostic script for axes #16898

Merged
merged 12 commits into from
Nov 20, 2024

Conversation

ahiuchingau
Copy link
Contributor

Overview

This PR adds evt tests for each axis in the Flex Stacker. Outline for the tests can be found here

@ahiuchingau ahiuchingau requested review from a team as code owners November 19, 2024 23:19
@ahiuchingau ahiuchingau requested a review from vegano1 November 20, 2024 15:59
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid, one minor name thing but honestly it's fine without it

# first make sure switch is not already triggered by moving in the opposite direction
if driver.get_limit_switch(axis, direction):
print(f"{direction} switch already triggered, moving away...\n")
SAFE_DISTANCE = 10 # mm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be safe_distance_mm = ...

@ahiuchingau ahiuchingau force-pushed the stacker_evt-script-test-axes branch from 9cd147b to 91c8db8 Compare November 20, 2024 22:54
@ahiuchingau ahiuchingau merged commit a34f2be into edge Nov 20, 2024
35 checks passed
@ahiuchingau ahiuchingau deleted the stacker_evt-script-test-axes branch November 20, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants