-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(protocol-designer): delete unused code #16869
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerader
added
the
DO NOT MERGE
Indicates a PR should not be merged, even if there's a shiny green merge button available
label
Nov 18, 2024
jerader
changed the title
start to delete unused code
feat(protocol-designer): delete unused code pt1
Nov 18, 2024
jerader
changed the title
feat(protocol-designer): delete unused code pt1
feat(protocol-designer): delete unused code
Nov 18, 2024
jerader
force-pushed
the
pd_clean-unused-code
branch
from
December 3, 2024 15:49
ffc2219
to
b8188b0
Compare
jerader
added
authorship
and removed
DO NOT MERGE
Indicates a PR should not be merged, even if there's a shiny green merge button available
labels
Dec 3, 2024
ddcc4
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stampstampstamp
koji
reviewed
Dec 3, 2024
koji
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for doing this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes AUTH-645
Overview
We are free to merge this in since the PD release will be off of the release branch!
This PR deletes unused code and moves a few components into the correct folder (such as
LabwareOnDeck
,getUnusedEntities
). There are also a few redux actions/selectors/reducers that were deleted because they are no longer in use. Those include:Additionally, all css style sheets are officially deleted 🗑️
Test Plan and Hands on Testing
Thoroughly smoke test locally.
Changelog
🗑️
Review requests
Risk assessment
medium? it deletes a bunch of code but it off of
edge