fix(api): rename TouchTipParams -> LiquidClassTouchTipParams to avoid name conflict #16848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Liquid classes defined a new class
TouchTipParamsto configure the touch-tip settings for a liquid. But there's already an existing class calledTouchTipParamsthat's used as the argument to the Protocol EnginetouchTipcommand. When we generate the command schema, both classes get pulled in, and the names clash.This PR renames the liquid class
TouchTipParamstoLiquidClassTouchTipParamsto avoid the conflict.Test Plan and Hands on Testing
I ran
make -C api test, everything seems to pass.Risk assessment
If this breaks anything, it should only affect our team for now.