Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hardware-testing): flex stacker EVT diagnostic script for connectivity #16835

Merged
merged 3 commits into from
Nov 18, 2024
Merged

feat(hardware-testing): flex stacker EVT diagnostic script for connectivity #16835

merged 3 commits into from
Nov 18, 2024

Conversation

ahiuchingau
Copy link
Contributor

Overview

In this PR, we're setting up a diagnostic script suite for the FLEX Stacker EVT development in hardware-testing.

The test_connectivity.py does the following:

  1. Validate serial communication by sending a GCode to prompt for device info, where we would verify the hw revision (EVT should show a1)
  2. Validate eeprom is working by sending a GCode to set serial number, then prompt for device info and ensure the serial number has been updated
  3. Prompt user input that the onboard LED is blinking

@ahiuchingau ahiuchingau requested review from a team as code owners November 14, 2024 19:57
sfoster1
sfoster1 approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nice work!

@ahiuchingau ahiuchingau force-pushed the PLAT-590-MCU-Validation branch from fd61488 to 91e4cf3 Compare November 14, 2024 22:45
vegano1
vegano1 approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@vegano1 vegano1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work, thank you!

@ahiuchingau ahiuchingau force-pushed the PLAT-590-MCU-Validation branch from 91e4cf3 to 6c9ddaf Compare November 18, 2024 16:08
@ahiuchingau ahiuchingau merged commit f433137 into edge Nov 18, 2024
34 checks passed
@ahiuchingau ahiuchingau deleted the PLAT-590-MCU-Validation branch November 18, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vegano1 vegano1 vegano1 approved these changes

@sfoster1 sfoster1 sfoster1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahiuchingau @sfoster1 @vegano1