Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): add error handling for failed maintenance run creation #16818

Merged

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Nov 14, 2024

Closes RABR-663 and RABR-667

Overview

During calibration flows, we currently don't have any error handling for failure to create a maintenance run. If a user exits pipette calibration and re-enters too quickly, for example, the "Move gantry to front" button is disabled indefinitely. This PR just adds some basic error handling if a maintenance run fails to be created successfully.

Screen.Recording.2024-11-14.at.10.47.04.AM.mov

Test Plan and Hands on Testing

  • See video

Changelog

  • The "Move Gantry to Front" button during calibration flows is no longer disabled indefinitely. Errors are now surfaced.

Risk assessment

low

@mjhuff mjhuff requested review from sfoster1, smb2268, ncdiehl11 and a team November 14, 2024 15:55
@mjhuff mjhuff requested a review from a team as a code owner November 14, 2024 15:55
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mjhuff mjhuff merged commit a0fe00f into chore_release-8.2.0 Nov 14, 2024
28 of 36 checks passed
@mjhuff mjhuff deleted the app_handle-calibration-maintenance-run-errors branch November 14, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants