fix: Opentrons ai client create protocol fixes #16802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbelginetw
requested review from
koji,
y3rsh,
shlokamin,
Elyorcv and
connected-znaim
connected-znaim
approved these changes
Nov 14, 2024
SyntaxColoring
pushed a commit
that referenced
this pull request
Nov 20, 2024
# Overview This PR fixes many defects opened by the Opentrons team and refactors some code to remove duplication defects [AUTH-1031](https://opentrons.atlassian.net/browse/AUTH-1031), [AUTH-1032](https://opentrons.atlassian.net/browse/AUTH-1032), [AUTH-1033](https://opentrons.atlassian.net/browse/AUTH-1033), [AUTH-1034](https://opentrons.atlassian.net/browse/AUTH-1034), [AUTH-1035](https://opentrons.atlassian.net/browse/AUTH-1035), [AUTH-1040](https://opentrons.atlassian.net/browse/AUTH-1040), [AUTH-1042](https://opentrons.atlassian.net/browse/AUTH-1042) ## Test Plan and Hands on Testing Retested manually ## Risk assessment low risk [AUTH-1031]: https://opentrons.atlassian.net/browse/AUTH-1031?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [AUTH-1032]: https://opentrons.atlassian.net/browse/AUTH-1032?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [AUTH-1033]: https://opentrons.atlassian.net/browse/AUTH-1033?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [AUTH-1034]: https://opentrons.atlassian.net/browse/AUTH-1034?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [AUTH-1035]: https://opentrons.atlassian.net/browse/AUTH-1035?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [AUTH-1040]: https://opentrons.atlassian.net/browse/AUTH-1040?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [AUTH-1042]: https://opentrons.atlassian.net/browse/AUTH-1042?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes many defects opened by the Opentrons team and refactors some code to remove duplication
defects AUTH-1031, AUTH-1032, AUTH-1033, AUTH-1034, AUTH-1035, AUTH-1040, AUTH-1042
Test Plan and Hands on Testing
Retested manually
Risk assessment
low risk