refactor(robot-server): Adjust SQL declarations to match reality #16799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SyntaxColoring
force-pushed
the
sql_parity_fixing
branch
from
d99f786 to
438bfd2
Compare
SyntaxColoring
commented
Nov 13, 2024
Comment on lines
+213
to
+216
| # nullable=True to match the underlying SQL, which is nullable because of a bug | ||
| # in the migration that introduced this column. This is not intended to ever be | ||
| # null in practice. | ||
| nullable=True, |
There was a problem hiding this comment.
Another way of explaining this, other than "migration bug," is that SQLite makes it very annoying to add non-nullable columns. Like, yeah, it's arguably a bug in the migration, but we'd have to go unusually far out of our way to avoid that bug, so is it really?
I'm happy to write whatever other people find more helpful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is step 2 towards fixing EXEC-827.
This retroactively edits our SQLAlchemy definitions to match what is actually running on robots. What is actually running on robots is decided by our migration system, and our migration system sometimes does manual
ALTER TABLEfixups that do not exactly match our SQLAlchemy definitions. See EXEC-827 for details.So this PR shows some constraints and indexes that were accidentally omitted. The next step after this PR is to find a way to actually get them back. We're figuring that out over in #16697 (comment). It will probably piggyback on the new migration, v7->v8, that that PR is adding.
Test Plan and Hands on Testing
The correctness of these reconciliations is checked by a test added in #16772.
Review requests
None in particular.
Risk assessment
Low. This shouldn't cause any behavioral change.