fix(protocol-designer): add dependent fields when tiprack changes #16790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerader
commented
Nov 13, 2024
Comment on lines
+144
to
+145
| 'tipRack', | ||
| 'nozzles' |
There was a problem hiding this comment.
added tiprack and nozzles as well in here because if the user changes the pipette, we probably want both of these fields to be reset as well.
koji
reviewed
Nov 13, 2024
| pipetteEntities: PipetteEntities | ||
| ): FormPatch => { | ||
| if (fieldHasChanged(rawForm, patch, 'tipRack')) { | ||
| const pipette = patch.pipette |
There was a problem hiding this comment.
nit
const { pipette } = patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes RQA-3541
Overview
Reset the flow rate fields when the tiprack changes, also reset the nozzle and tiprack fields when pipette changes. For mix and transfer forms
Test Plan and Hands on Testing
Create a protocol and add 3 tipracks for 1 pipette. Create a transfer form and add a custom aspirate and dispense flow rate. then go back and change the tiprack to another one. see that the flow rates got reset back to default. Test it also with the mix form.
Changelog
Risk assessment
low