fix(protocol-designer): fix multi-channel to single-channel switch issue with trash bin destination #16789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sue with trash bin destination fix RQA-3543
jerader
reviewed
Nov 13, 2024
Comment on lines
517
to
518
| // @ts-expect-error(sa, 2021-6-14): appliedPatch.pipette does not exist. Address in #3161 | ||
| const pipetteId: string = appliedPatch.pipette |
There was a problem hiding this comment.
does this work? I know there are a bunch of ts-expect-errors in this file but if this way works, i'd prefer to limit our usage of ts-expect-errors when possible. At some point we need to create the types for appliedPatch fully 😄
Suggested change
| // @ts-expect-error(sa, 2021-6-14): appliedPatch.pipette does not exist. Address in #3161 | |
| const pipetteId: string = appliedPatch.pipette | |
| const pipetteId: string = appliedPatch.pipette as string |
There was a problem hiding this comment.
yes this does work! should i also make this change on line 487?
There was a problem hiding this comment.
or i'll move it outside of the conditional statement as they both used pipetteId
jerader
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix RQA-3543
Overview
Fixing a TypeError when switching from a multi-channel to a single-channel pipette with the trash bin or waste chute as the destination labware, caused by an inability to get the labware definition for these destinations.
Test Plan and Hands on Testing
Changelog
dispense_wellswith a multi-channel pipette. UsedgetDefaultWellsfor the trash bin/waste chute, as they lack well locations and labware definitions.Review requests
Risk assessment