feat(opentrons-ai-client): filter out retired and old labware #16775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shlokamin
requested review from
ncdiehl11,
connected-znaim and
fbelginetw
and removed request for
a team and
ncdiehl11
shlokamin
commented
Nov 12, 2024
| import type { LabwareDefByDefURI } from '@opentrons/shared-data' | ||
|
|
||
| let _definitions: LabwareDefByDefURI | null = null | ||
| export function getAllDefinitions(): LabwareDefByDefURI { |
There was a problem hiding this comment.
added our own labware getter in the ai project so we can cache all labware (which includes our filter).
if we only did this in the labware modal, the issue is that the filter would never get applied since the _definitions private object only gets instantiated once
|
oopsy need to fix some tests |
fbelginetw
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR filters out old and no longer supported labware for use in all of the opentrons ai app.
Changelog
Review requests
Make sure old labware (like GEB tip racks) no longer show up in the app
Risk assessment
Low