Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(abr-testing): ABR protocols and Liquid Set Ups #16728

Merged
merged 67 commits into from
Nov 8, 2024
Merged

feat(abr-testing): ABR protocols and Liquid Set Ups #16728

merged 67 commits into from
Nov 8, 2024

Conversation

rclarke0
Copy link
Contributor

@rclarke0 rclarke0 commented Nov 7, 2024 •
edited
Loading

Overview

Current ABR Protocols and Liquid Set Ups

Test Plan and Hands on Testing

All protocols have been simulated and ran on ABR robots successfully.

Changelog

  • Protocols include helper functions to load commonly used parameters, module/adapter/labware set ups, loading liquids, probing liquids, measuring height of loaded liquids
  • Protocols follow format and linting rules, excluding flake8 complexity score.

Review requests

Risk assessment

  • Protocols will no longer be able to be analyzed on the app, but will work on the robot as long as the abr-testing folder is pushed to it. However, protocols will still be analyzed using the abr make simulate command.

rclarke0 added 30 commits July 23, 2024 17:27
@rclarke0
increase google sheet columns
cde88cb
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
e534a8f
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
e200e8c
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
022dcb0
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
0cbcd1b
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
9628c49
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
9f2d693
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
728c2e1
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
31d0596
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
2bbcc3e
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
916f496
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
ebf6c72
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
56aa6dd
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
17cadc6
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
378ae28
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
68d6778
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
43fcb8a
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
7ed3f7d
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
7fda077
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
d40b067
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
0f0d482
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
02f92cb
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
a50bb16
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
20a4087
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
3a5d003
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
4b80358
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
7dc9204
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
d7ee6d4
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
c9dfbf6
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
293ba96
rclarke0 added 13 commits October 22, 2024 15:58
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
c8a29d0
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
adcd2a9
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
8bfd478
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
a431735
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
6b460db
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
73107de
@rclarke0
Merge branch 'edge' of https://github.com/Opentrons/opentrons into edge
a030bcc
@rclarke0
liquid fill protocls
8f2c3ee
@rclarke0
abr protocols, removed flake complexity for protocols
30ab75d
@rclarke0
calibration run command
4b1341b
@rclarke0
protocol drafts
04c266f
@rclarke0
lint and formatting issues
f5f28b6
@rclarke0
abr protocols and liquid set ups
8ba70e9
@rclarke0 rclarke0 requested review from a team as code owners November 7, 2024 20:18
sfoster1
sfoster1 approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, pushed a change to avoid linting the protocols.

@rclarke0 rclarke0 merged commit 18b0eb4 into edge Nov 8, 2024
53 of 58 checks passed
@rclarke0 rclarke0 deleted the add-abr-protocols branch November 8, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfoster1 sfoster1 sfoster1 approved these changes

@AnthonyNASC20 AnthonyNASC20 Awaiting requested review from AnthonyNASC20

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rclarke0 @sfoster1