fix(protocol-designer): liquids show up when zooming into slot #16717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clsoes RQA-3524
Overview
This fixes a bug where if you edit a slot that has liquid in it, the liquid wasn't showing up. There is still a slightly buggy experience where if you press "done" the liquids get deleted. that will be fixed in a follow up.
Test Plan and Hands on Testing
Upload the attached protocol and zoom into the 2 slots with labware that have liquids. see that the liquids are retained when zooming in. the liquids are NOT retained when you press done, that is a separate issue that will be resolved later
1.0 testing.json
Changelog
Risk assessment
low