feat(shared-data, api): Add evo tips definition and restrictions on loading #16710
+1,124
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Laura-Danielle
force-pushed
the
PLAT-350-add-evo-tips-tiprack
branch
from
66da179 to
c87dde7
Compare
sfoster1
requested changes
Dec 10, 2024
| @@ -363,6 +372,27 @@ def ensure_definition_is_labware(definition: LabwareDefinition) -> None: | |||
| ) | |||
|
|
|||
|
|
|||
| def ensure_labware_is_loadable( | |||
There was a problem hiding this comment.
This wants to be in the engine I reckon
Laura-Danielle
force-pushed
the
PLAT-350-add-evo-tips-tiprack
branch
from
bc3405e to
e01dcbe
Compare
Laura-Danielle
requested review from
smb2268 and
sfoster1
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #16710 +/- ##
===========================================
- Coverage 92.43% 79.21% -13.23%
===========================================
Files 77 120 +43
Lines 1283 4533 +3250
===========================================
+ Hits 1186 3591 +2405
- Misses 97 942 +845
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add evo tips definition but as a labware so that liquid handling actions can happen in the 'labware'.
Test Plan and Hands on Testing
Need to check that the stackup works as expected
Changelog
Review requests
Check that the labware role makes sense and the stacking part.
Risk assessment
Low. Adding a new labware.