fix(app): Fix flickering screen during gripper Error Recovery #16667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes RQA-3486
Overview
Fixes an infinite re-render caused by control flow issues. Once the robot is on an "in motion" screen, we are no longer on an
isManualGripperStep, setting some state a little too eagerly and causing the loop.Note that the ticket specifies another bug, but the embedded folks are looking at that part.
Fixed Behavior
Screen.Recording.2024-11-01.at.12.54.26.PM.mov
Test Plan and Hands on Testing
Changelog
Risk assessment
low