fix(step-generation): configureForVolume now volumes the chunk instea… #16666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncdiehl11
approved these changes
Nov 1, 2024
There was a problem hiding this comment.
This makes sense to me. If I'm understanding, there will never be a set of chunks (including aspirate volume + air gap) whose volume occupy less than half the tip capacity (or else they wouldn't be chunks!). So I think this is academic, but it is more accurate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d of volume
Overview
This fixes a step-generation bug regarding the volume for
configureForVolumecommand. Unclear if this actually causes issues in the field but its an error because its configuring for the full volume instead of the chunk volume (in case there are multiple aspirates for one transfer step)Test Plan and Hands on Testing
Just check the logic, i don't think there is anything worth manually testing??
Changelog
change volume amount from full volume to chunk
Risk assessment
low