Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(app): adjust ODD simple style predefined location option margin #16661

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Oct 31, 2024

Closes EXEC-798

Overview

Fixes a continue/go back margin issue with simple style drop tip flows on the ODD. Unfortunately the fix is unideal for two reasons:

  • There are easy CSS properties to get the margin to work correctly when the list of drop tip locations is less than 3 (ie, they don't overflow on the screen), but the go back/continue buttons are entirely occluded when there is overflow because...
  • Some ODD-specific CSS (overflow behavior) in the RadioButton component causes unexpected behavior. Unfortunately, there are a lot of child components which are also in the components directory, and I'd rather avoid touching all these widely-used components during bug-fix phase. I've talked to some other FE devs, and we can revisit RadioButton after the release if the issue isn't solved by ongoing AUTH work.

Current Behavior

Screenshot 2024-10-31 at 4 24 26 PM

Fixed Behavior

Screenshot 2024-10-31 at 4 23 49 PM

Test Plan and Hands on Testing

  • Ran all permutations of drop tip wizard in and out of Error Recovery and confirmed the CSS is correct.

Risk assessment

low

@mjhuff mjhuff requested a review from a team October 31, 2024 20:36
@mjhuff mjhuff requested a review from a team as a code owner October 31, 2024 20:36
@mjhuff mjhuff requested review from smb2268 and removed request for a team and smb2268 October 31, 2024 20:36
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ugh

@mjhuff mjhuff merged commit a6bd20a into chore_release-8.2.0 Nov 1, 2024
36 checks passed
@mjhuff mjhuff deleted the app_fix-drop-tip-margin branch November 1, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants