fix(app): Fix tip selection during Error Recovery #16659
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes RQA-3472
Overview
#16628 fixed stale well issues, but introduced a regression, specifically this code:
Uhhh, woops. Effectively, we were always updating the well location to be the initial location any time the well location was changed.
Looking back on the
useInitialSelectedLocationsFrom
hook in general, we don't really need this additional, internal state within a hook, so let's remove it.Test Plan and Hands on Testing
Changelog
Risk assessment
low