Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): Fix tip selection during Error Recovery #16659

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Oct 31, 2024

Closes RQA-3472

Overview

#16628 fixed stale well issues, but introduced a regression, specifically this code:

// Set the initial locs when they first become available or update.
  if (selectedLocs !== initialLocs) {
    setSelectedLocs(initialLocs)
  }

Uhhh, woops. Effectively, we were always updating the well location to be the initial location any time the well location was changed.

Looking back on the useInitialSelectedLocationsFrom hook in general, we don't really need this additional, internal state within a hook, so let's remove it.

Test Plan and Hands on Testing

  • Verified correct behavior for all permutations of tip selection during Error Recovery:
  • "Full" pipette config on the 1ch/8ch. User can select any well.
  • Partial tip config. User is not allowed to select any well.
  • Error Recovery the 2nd+ time. The stale data problem is still avoided (see fix(app): fix stale well location in Error Recovery #16628 for context).

Changelog

  • Fixed tip selection during Error Recovery not allowing users to select tips.

Risk assessment

low

@mjhuff mjhuff requested a review from a team October 31, 2024 20:11
@mjhuff mjhuff requested a review from a team as a code owner October 31, 2024 20:11
@mjhuff mjhuff requested review from ncdiehl11 and removed request for a team and ncdiehl11 October 31, 2024 20:11
@mjhuff mjhuff merged commit e63686b into chore_release-8.2.0 Nov 1, 2024
30 checks passed
@mjhuff mjhuff deleted the app_fix-tip-selection-error-recovery branch November 1, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants