feat(shared-data): Add the ability to handle sub wells in labware geometry #16658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SyntaxColoring
approved these changes
Oct 31, 2024
shared-data/labware/schemas/3.json
Outdated
Comment on lines
159
to
160
| "count": { | ||
| "type": "number" |
There was a problem hiding this comment.
Interesting—your math doesn't change either way, but I would consider splitting this into xCount and yCount for visualization reasons.
| @@ -272,6 +284,7 @@ def height_at_volume_within_section( | |||
| section_height: float, | |||
| ) -> float: | |||
| """Calculate a height within a bounded section according to geometry.""" | |||
| target_volume_relative = target_volume_relative / section.count | |||
There was a problem hiding this comment.
I think we may not have to do this for height to volume ? In the two cases where height is given, either:
- The height is not in the subwell: the calculation doesnt change
- the height is within the subwells: the volume we're trying to find is contained only within the one subwell we're getting the liquid height from
There was a problem hiding this comment.
This is still correct, if we want to be say 24ul above the bottom and there are 8 subwells, we need to find the height in 1 subwell that equals (24/8)=3ul if we didn't do the division, then we would be trying to find where it would be 24ul in 1 subwell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Some Labware, particularly larger reservoirs have wells that have "sub well" geometry at the bottom, such as the Nest 1 well 195ml, which is one well with 96 little pyramids at the bottom.
This PR lets there be a "count" field in the geometry stack up which tells the system that there are "count" number of sub features in this well.
For the Height->Volume, we do the normal height->volume of one of these sub features and then multiple the resulting volume by "count"
For Volume-Height, we first divide the volume by "count" to get the volume change in one sub well and then do the normal calculation.
Test Plan and Hands on Testing
Changelog
Review requests
Risk assessment