Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol-designer): fix the display when dropdown menu option is only one #16640

Merged
merged 5 commits into from
Nov 5, 2024

Conversation

koji
Copy link
Contributor

@koji koji commented Oct 30, 2024

Overview

fix the display when dropdown menu option is only one and update copies.
https://opentrons.slack.com/archives/C07E9T2NAQK/p1730494043739239

Screenshot 2024-11-01 at 6 44 19 PM

@jerader @ncdiehl11
As you can see there is a small gap in Volume per wells (there would be a few similar cases that use InputForm) because components/src/atoms/InputField/index.tsx
Obviously, removing padding is easy but it will have a kind of big impact on PD? (I guess there wouldn't no issue on Desktop app?)

Do you think we should fix this now?

    const TITLE_STYLE = css`
      color: ${COLORS.grey60};
      padding-bottom: ${SPACING.spacing4};  ← this one
      text-align: ${textAlign};
      @media ${RESPONSIVENESS.touchscreenMediaQuerySpecs} {
        font-size: ${TYPOGRAPHY.fontSize22};
        font-weight: ${TYPOGRAPHY.fontWeightRegular};
        line-height: ${TYPOGRAPHY.lineHeight28};
        justify-content: ${textAlign};
      }
    `

close RQA-3434

Test Plan and Hands on Testing

Changelog

Review requests

low

Risk assessment

low

…ly one

fix the display whendropdownmenu option is only one

close RQA-3434
@koji koji requested review from ncdiehl11 and jerader October 30, 2024 18:09
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes sense to me!

@koji
Copy link
Contributor Author

koji commented Oct 31, 2024

  • update text
  • fix tests errors

@koji koji requested a review from jerader November 1, 2024 22:46
@koji koji marked this pull request as ready for review November 2, 2024 00:13
@koji koji requested review from a team as code owners November 2, 2024 00:13
@koji koji removed request for a team November 4, 2024 18:08
@koji koji merged commit 8040b74 into edge Nov 5, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants