fix(protocol-designer, component): fixes RadioButton and update path tooltip #16635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syao1226
changed the title
…com/Opentrons/opentrons into protocol_designer-path-double-click
syao1226
force-pushed
the
protocol_designer-path-double-click
branch
from
1f259f7 to
0f513ca
Compare
added 3 commits
October 31, 2024 10:31
…com/Opentrons/opentrons into protocol_designer-path-double-click
syao1226
requested review from
jerader and
koji
and removed request for
a team
koji
reviewed
Oct 31, 2024
Comment on lines
114
to
120
| css={ | ||
| isSelected | ||
| ? SELECTED_BUTTON_STYLE | ||
| : disabled | ||
| ? DISABLED_BUTTON_STYLE | ||
| : AVAILABLE_BUTTON_STYLE | ||
| } |
There was a problem hiding this comment.
we avoid using a nested ternary operator
There was a problem hiding this comment.
oh i'll create a helper function to handle this
koji
reviewed
Oct 31, 2024
| disabled: boolean | ||
| largeDesktopBorderRadius: boolean | ||
| isLarge: boolean | ||
| maxLines?: number | null |
There was a problem hiding this comment.
i'm not sure. does setting it to null means it has no line limit? but it's an optional prop
koji
reviewed
Oct 31, 2024
koji
reviewed
Oct 31, 2024
koji
reviewed
Oct 31, 2024
protocol-designer/src/pages/Designer/ProtocolSteps/StepForm/PipetteFields/PathField.tsx
Outdated
Show resolved
Hide resolved
koji
reviewed
Oct 31, 2024
protocol-designer/src/pages/Designer/ProtocolSteps/StepForm/PipetteFields/PathField.tsx
Outdated
Show resolved
Hide resolved
koji
reviewed
Oct 31, 2024
protocol-designer/src/pages/Designer/ProtocolSteps/StepForm/PipetteFields/PathField.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix RQA-3270, re AUTH-862
Overview
Updating the
RadioButtoncomponent to fix the "double-clicking" behavior when quickly clicking through different paths in the Transfer step. Also updating the GIF images for path animation.Test Plan and Hands on Testing
Changelog
styledcomponents outside theRadioButtoncomponent to prevent them from being created dynamicallyReview requests
Risk assessment