Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shared-data): add schema 3 versions of json files with inner labware geometry #16618

Merged
merged 22 commits into from
Oct 30, 2024

Conversation

ryanthecoder
Copy link
Contributor

Overview

This takes the physical measurements the hardware team did and adds it to the json data. Will continue to flesh this out as more labware are tested and verified.

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

@ryanthecoder ryanthecoder force-pushed the EXEC-793-add-inner-geometry branch 3 times, most recently from d348e2b to 31506c7 Compare October 29, 2024 18:45
@ryanthecoder ryanthecoder marked this pull request as ready for review October 29, 2024 19:54
@ryanthecoder ryanthecoder requested review from a team as code owners October 29, 2024 19:54
@ryanthecoder ryanthecoder force-pushed the EXEC-793-add-inner-geometry branch from 0f77f30 to 555dcab Compare October 29, 2024 20:13
@ryanthecoder ryanthecoder force-pushed the EXEC-793-add-inner-geometry branch from 555dcab to bcaf976 Compare October 29, 2024 20:26
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It makes me feel a little weird to have the geometry definition references just be like "a" though - maybe we can call those "main" or a uuid or something?

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good once we fix CI

@caila-marashaj caila-marashaj merged commit 0965fd3 into edge Oct 30, 2024
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants