chore: fix github workflow and failing tests #16593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What a nightmare
Vitest doesn't support the copying versions of array reordering functions from baseline 2023, so for now replace them. That's easy for the dashboard because we can just replace .toReversed().reduce(...) with .reduceRight(...) but for the historic run sorting we have to elementwise copy with .map(t=>t) and then sort in-place. Yuck!
sfoster1
requested review from
ncdiehl11 and
brenthagen
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Messed up the app test workflow so it wasn't running and therefore we didn't notice some tests were failing. Fix the workflow, fix the tests.
Only changes of note are that vitest doesn't support baseline 2023 copying array reorder functions for some reason so replace them with equivalents.