Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api): don't use sensor log on ot2 or simulators #16590

Merged
merged 1 commit into from
Oct 24, 2024
Merged

fix(api): don't use sensor log on ot2 or simulators #16590

merged 1 commit into from
Oct 24, 2024

Conversation

ryanthecoder
Copy link
Contributor

Overview

This makes is so the logging setup only tries to import the sensor log name if it's running on a Flex.

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

@ryanthecoder ryanthecoder requested a review from a team as a code owner October 24, 2024 14:54
SyntaxColoring
SyntaxColoring approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@SyntaxColoring SyntaxColoring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if it’s been tested and works, thanks!

I wonder why our usual CI tests didn’t catch this.

@ryanthecoder ryanthecoder merged commit 9d57048 into edge Oct 24, 2024
27 checks passed
@SyntaxColoring SyntaxColoring mentioned this pull request Oct 30, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SyntaxColoring SyntaxColoring SyntaxColoring approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanthecoder @SyntaxColoring