fix(protocol-designer): fix ListItemDescriptor content and description alignment issue #16588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n alignment issue fix ListItemDescriptor content and description alignment issue close RQA-3424
koji
commented
Oct 24, 2024
Comment on lines
+269
to
+272
| minWidth="13.75rem" | ||
| alignItems={ALIGN_CENTER} | ||
| gridGap={SPACING.spacing8} | ||
| width="13.75rem" |
There was a problem hiding this comment.
Liquid is a special case since the description is a user input and we don't know the width of description.
koji
commented
Oct 24, 2024
| ) : ( | ||
| '' | ||
| ) | ||
| <Flex minWidth="13.75rem"> |
There was a problem hiding this comment.
13.75rem is Mel's request. ListItemDesciptor's description always keep 220px.
jerader
reviewed
Oct 24, 2024
Comment on lines
+14
to
15
| import type { FC } from 'react' | ||
| import { FLEX_ROBOT_TYPE } from '@opentrons/shared-data' |
There was a problem hiding this comment.
Suggested change
| import type { FC } from 'react' | |
| import { FLEX_ROBOT_TYPE } from '@opentrons/shared-data' | |
| import { FLEX_ROBOT_TYPE } from '@opentrons/shared-data' | |
| import type { FC } from 'react' |
jerader
reviewed
Oct 24, 2024
| description={t('robotType')} | ||
| description={ | ||
| <Flex minWidth="13.75rem"> | ||
| {' '} |
jerader
reviewed
Oct 24, 2024
| content={pipetteInfo(leftPipette)} | ||
| description={ | ||
| <Flex minWidth="13.75rem"> | ||
| {' '} |
jerader
reviewed
Oct 24, 2024
| content={pipetteInfo(rightPipette)} | ||
| description={ | ||
| <Flex minWidth="13.75rem"> | ||
| {' '} |
jerader
reviewed
Oct 24, 2024
| content={isGripperAttached ? t('gripper') : t('na')} | ||
| description={ | ||
| <Flex minWidth="13.75rem"> | ||
| {' '} |
jerader
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
fix ListItemDescriptor content and description alignment issue
remove
stringtype fromdescriptionandcontent.There are 2 types in the design, but actually we need to use ListDescriptor in SlotInfo that has 118.5px as width.
Technically we can add a condition to switch 3 types but at this moment we don't know how Desktop app and other web application use it. For this change, we might need to write a little bit more lines, but it makes things easy since we can pass
JSX.Elementthat we style or layout separately.design
https://www.figma.com/design/WbkiUyU8VhtKz0JSuIFA45/Feature%3A-Protocol-Designer-Phase-1?node-id=10092-334055&m=dev
SlotDetails
before
after
Protocol Overview
Protocol Metadata
Instruments
Liquid Definitions
Protocol Steps
Materials List
close RQA-3424
Test Plan and Hands on Testing
Changelog
Review requests
Risk assessment