Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol-designer, components): revamp form errors and fix logic for rendering #16576

Merged
merged 4 commits into from
Oct 24, 2024

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Oct 23, 2024

closes AUTH-972

Overview

Wires up form errors and updates the copy.

Test Plan and Hands on Testing

Create a protocol and add a transfer step. have it transfer from 2 wells into 3 wells and see the form error which should render immediately at the top of the form.

Changelog

  • add the onBlur and onFocus fields to the dropdownMenu component so the errors render as expected in PD
  • add the hasBackgroundError boolean to input field for a form error in PD
  • update copy
  • fix bug with the errors not rendering immediately

Risk assessment

low

@jerader jerader requested review from a team as code owners October 23, 2024 16:26
@jerader jerader requested review from mjhuff and removed request for a team October 23, 2024 16:26
@jerader jerader changed the title feat(protocol-designer): revamp form errors and fix logic for rendering feat(protocol-designer, components): revamp form errors and fix logic for rendering Oct 23, 2024
@jerader jerader requested review from koji and ncdiehl11 and removed request for a team and mjhuff October 23, 2024 16:26
@koji
Copy link
Contributor

koji commented Oct 24, 2024

one thing on Banner

Screenshot 2024-10-24 at 11 52 30 AM

need to add iconMarginLeft={SPACING.spacing4} to Banner.

Screenshot 2024-10-24 at 11 56 23 AM

Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a comment but the changes look good to me, and it worked as expected.

@jerader jerader merged commit eb83705 into edge Oct 24, 2024
62 checks passed
@jerader jerader deleted the pd_form-errors branch October 24, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants