feat(protocol-designer): add step names to protocol steps and disable overflow menu buttons #16571
+93
−51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR addresses two major tasks: 1) adding the step name above deck map in ProtocolSteps component, and 2) appropriately disabling buttons from step overflow menus when appropriate. Namely, when a step is in editing, its overflow menu should not permit viewing details (for transfer and thermocycler profile steps). When a step form has unsaved changes, its overflow menu should not permit duplication. If batch edit is open, neither steps's overflow menu should permit batch duplication. Deletion is available in any scenario. Also, the opening of a step form edit toolbox takes priority over step details toolbox.
In addition, I pass the
zIndex
prop forToolbox
only if it is of position fixed.Closes AUTH-878, Closes AUTH-880
Test Plan and Hands on Testing
overflow menu
Screen.Recording.2024-10-22.at.4.45.50.PM.mov
step names
Changelog
Review requests
see test plan
Risk assessment
low