Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol-designer): add step names to protocol steps and disable overflow menu buttons #16571

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Oct 22, 2024

Overview

This PR addresses two major tasks: 1) adding the step name above deck map in ProtocolSteps component, and 2) appropriately disabling buttons from step overflow menus when appropriate. Namely, when a step is in editing, its overflow menu should not permit viewing details (for transfer and thermocycler profile steps). When a step form has unsaved changes, its overflow menu should not permit duplication. If batch edit is open, neither steps's overflow menu should permit batch duplication. Deletion is available in any scenario. Also, the opening of a step form edit toolbox takes priority over step details toolbox.

In addition, I pass the zIndex prop for Toolbox only if it is of position fixed.

Closes AUTH-878, Closes AUTH-880

Test Plan and Hands on Testing

overflow menu

Screen.Recording.2024-10-22.at.4.45.50.PM.mov
  • create or upload a protocol with multiple transfer steps
  • open a transfer step overflow menu and select 'view details'. Verify that the step details toolbox opens
  • with details open, open the step's overflow menu again, select "edit step". Verify that the stepform edit toolbox opens and replaces the step details toolbox
  • with edit toolbox open, open the step's overflow menu again. Verify that only "duplicate step" and "delete step" options are enabled
  • modify any field in the edit toolbox, open the step's overflow menu again. Verify that only "delete step" option is enabled
  • close this toolbox and control+click two transfer steps to open batch edit toolbox
  • verify that "duplicate steps" and "delete steps" options are enabled
  • modify any field in the batch edit toolbox, open the step's overflow menu again. Verify that only "delete steps" option is enabled

step names

  • select or hover any step
  • verify that the steps default or custom name displays above the deck map

Changelog

  • add step names
  • update logic for disabling overflow menu items
  • add tests
  • fix small styling throughout ProtocolSteps sub components

Review requests

see test plan

Risk assessment

low

… overflow menu buttons

This PR addresses two major tasks: 1) adding the step name above deck map in ProtocolSteps
component, and 2) appropriately disabling buttons from step overflow menus when appropriate. Namely,
when a step is in editing, its overflow menu should not permit viewing details (for transfer and
thermocycler profile steps). When a step form has unsaved changes, its overflow menu should not
permit duplication. If batch edit is open, neither steps's overflow menu should permit batch
duplication. Deletion is available in any scenario. Also, the opening of a step form edit toolbox
takes priority over step details toolbox.

Closes AUTH-878, Closes AUTH-880
@ncdiehl11 ncdiehl11 self-assigned this Oct 22, 2024
@ncdiehl11 ncdiehl11 requested review from jerader and koji October 22, 2024 20:47
@ncdiehl11 ncdiehl11 marked this pull request as ready for review October 22, 2024 20:49
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner October 22, 2024 20:49
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner October 22, 2024 20:51
@ncdiehl11 ncdiehl11 removed request for a team October 22, 2024 21:24
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ncdiehl11 ncdiehl11 merged commit 2f8a751 into edge Oct 23, 2024
34 checks passed
@ncdiehl11 ncdiehl11 deleted the pd_step-names-overflow-menu branch October 23, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants