fix(app): store run step completion in redux #16570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a redux substore for the setup step completion status that we'll use in place of react state.
mjhuff
reviewed
Oct 22, 2024
| @@ -68,4 +71,5 @@ export const rootReducer: Reducer<State, Action> = combineReducers({ | |||
| sessions: sessionReducer, | |||
| calibration: calibrationReducer, | |||
| protocolStorage: protocolStorageReducer, | |||
| protocolRuns: protocolRunReducer, | |||
There was a problem hiding this comment.
I'm very excited about this!
| ), | ||
| }) | ||
| ) | ||
| }, [runId, protocolAnalysis, dispatch]) |
There was a problem hiding this comment.
I have a feeling this could cause an infinite re-render, but I could be wrong. We probably want to do something like protocolAnalysis.key.
There was a problem hiding this comment.
Yup this happened instantly. This can be either a robot-side or app-side analysis so we have to try the id too but it works when you do that.
There was a problem hiding this comment.
Do we want some sort of store update here if a run is already in progress, and we don't actually need any setup, rather than forgoing the top level setup field?
protocol analyses are absolutely not safe to use as hook dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[It turns out that since we implemented the green checks displayed for completed steps as react component state, if you navigate away from the component it loses the state.
To fix this we can throw it in redux. This PR does that, in the app anyway.
testing
reviews
Closes RQA-3304