Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol-designer, step-generation): timeline warnings and error… #16566

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Oct 22, 2024

…s revamp

closes AUTH-889

Overview

Only addresses timeline warnings and errors. The form warnings & errors will be in a followup

Screenshot 2024-10-22 at 14 23 50

Test Plan and Hands on Testing

Create a protocol with a pipetting step and then go back and delete the tiprack. should see the not enough tips error on the timeline on the protocol steps tab

Changelog

  • update copy for a bunch of timeline errors and warnings
  • wires up the ability to click to go to starting deck state
  • adds a new redux action and key for determining the designer tab you are selected on
  • fixes tests

Risk assessment

low

@jerader jerader requested a review from a team as a code owner October 22, 2024 18:25
@jerader jerader requested review from koji and ncdiehl11 October 22, 2024 18:25
@jerader jerader force-pushed the pd_timeline-errors-warnings branch from 5b917b8 to 44fc0d9 Compare October 23, 2024 12:52
@jerader jerader requested a review from koji October 23, 2024 13:08
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jerader jerader merged commit 42699e3 into edge Oct 23, 2024
29 checks passed
@jerader jerader deleted the pd_timeline-errors-warnings branch October 23, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants