fix(protocol-designer): update ListItemDescriptor to align with the latest design #16563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atest design update ListItemDescriptor to align with the latest design close AUTH-895
koji
commented
Oct 22, 2024
| </Flex> | ||
| } | ||
| description={ | ||
| <Flex width="2.875rem"> |
There was a problem hiding this comment.
this width is a request from Mel (46px)
syao1226
reviewed
Oct 22, 2024
| @@ -2,43 +2,35 @@ import { Flex } from '../../../primitives' | |||
| import { | |||
| ALIGN_FLEX_START, | |||
| DIRECTION_ROW, | |||
| FLEX_AUTO, | |||
| // FLEX_AUTO, | |||
ncdiehl11
approved these changes
Oct 22, 2024
| @@ -2,43 +2,35 @@ import { Flex } from '../../../primitives' | |||
| import { | |||
| ALIGN_FLEX_START, | |||
| DIRECTION_ROW, | |||
| FLEX_AUTO, | |||
| // FLEX_AUTO, | |||
|
|
||
| export const BUTTON_LINK_STYLE = css` | ||
| color: ${COLORS.grey60}; | ||
| &:hover { | ||
| color: ${COLORS.grey40}; | ||
| } | ||
| ` | ||
|
|
||
| export const LINE_CLAMP_TEXT_STYLE = ( |
There was a problem hiding this comment.
This may be overkill, but I am thinking of a more robust way to retrieve labware name on a module better than simply splitting on "on". Maybe:
const timeline = useSelector(getRobotStateAtActiveItem)
const labware = timeline?.labware ?? {}
let labwareOnModuleId: string | null = null
for (const [id, lw] of Object.entries(labware)) {
if (lw.slot === formData.moduleId) {
labwareOnModuleId = id
break
}
}
const nickname =
labwareOnModuleId != null
? useSelector(getLabwareNicknamesById)[labwareOnModuleId ?? '']
: null
const moduleDisplayName = getModuleDisplayName(moduleModel)
can work, and we can use an escape hatch if this returns null. I also think this may be beyond the scope of this PR's intention, and I am happy to address it later
There was a problem hiding this comment.
@ncdiehl11 I think we can do that in another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
update ListItemDescriptor to align with the latest design
design
https://www.figma.com/design/WbkiUyU8VhtKz0JSuIFA45/Feature%3A-Protocol-Designer-Phase-1?node-id=10092-334055&m=dev
previous
default->largeprevious
mini->defaultadd a CSS style to atoms for line clamp.
close AUTH-895
Test Plan and Hands on Testing
Changelog
Review requests
Risk assessment
low