Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(components, protocol-designer): add Thermocycler step details UI #16560

Merged
merged 6 commits into from
Oct 22, 2024
Merged

feat(components, protocol-designer): add Thermocycler step details UI #16560

merged 6 commits into from
Oct 22, 2024

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Oct 22, 2024 •
edited
Loading

Overview

Similar to viewing substeps detail for moveLiquid type steps, this PR adds UI for thermocycler substep details. Also, I move the step details toolbox to the right side of the screen as designs specify, and make a few other small styling changes to our ListItem, Toolbox, and StepOverFlowMenu components.

Closes AUTH-882

Test Plan and Hands on Testing

  • create or import a protocol (example) that contains a Thermocycler profile step
  • on the step's overflow menu, select 'View details'
  • verify that the step details correctly populate in a toolbox on the right side of the app
Screen.Recording.2024-10-22.at.10.41.23.AM.mov

Changelog

  • wire up Thermocycler substeps content
  • move the substeps toolbox to the right of the screen
  • add small style changes to ListItem padding and Toolbox width/padding
  • add tests

Review requests

  • see test plan

Risk assessment

low

@ncdiehl11
feat(components, protocol-designer): add Thermocycler step details UI
d160c3e 
Similar to viewing substeps detail for moveLiquid type steps, this PR adds UI for thermocycler
substep details. Also, I move the step details toolbox to the right side of the screen as designs
specify, and make a few other small styling changes to our ListItem, Toolbox, and StepOverFlowMenu
components.

Closes AUTH-882
@ncdiehl11 ncdiehl11 self-assigned this Oct 22, 2024
@ncdiehl11 ncdiehl11 marked this pull request as ready for review October 22, 2024 14:42
@ncdiehl11 ncdiehl11 requested review from a team as code owners October 22, 2024 14:42
@ncdiehl11 ncdiehl11 requested review from mjhuff, koji and jerader and removed request for a team and mjhuff October 22, 2024 14:42
@koji
Copy link
Contributor

koji commented Oct 22, 2024

For time format
https://www.figma.com/design/WbkiUyU8VhtKz0JSuIFA45?node-id=11196-717807&m=dev#996135175

@ncdiehl11 ncdiehl11 requested review from koji and jerader October 22, 2024 17:35
koji
koji approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ncdiehl11 ncdiehl11 merged commit 37e81a0 into edge Oct 22, 2024
24 checks passed
@ncdiehl11 ncdiehl11 deleted the pd_thermocycler-substeps branch October 22, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koji koji koji approved these changes

@jerader jerader Awaiting requested review from jerader

Assignees

@ncdiehl11 ncdiehl11

Labels
authorship
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ncdiehl11 @koji @jerader