Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol-designer): update privacy settings copy #16534

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

ncdiehl11
Copy link
Collaborator

Overview

Updates PD privacy settings copy according to latest legal recommendations. Adds links within copy to direct to privacy policy and opentrons EULA.

Closes AUTH-902

Test Plan and Hands on Testing

  • Launch PD with redesign and inspect settings page
  • Verify that privacy settings copy matches that in attached ticket, and links direct to correct URLs

Changelog

  • update copy for privacy settings
  • update tests

Review requests

see test plan

Risk assessment

medium. need to be extra sure copy is correct

Updates PD privacy settings copy according to latest legal recommendations. Adds links within copy
to direct to privacy policy and opentrons EULA.

Closes AUTH-902
@ncdiehl11 ncdiehl11 requested a review from koji October 18, 2024 16:49
@ncdiehl11 ncdiehl11 marked this pull request as ready for review October 18, 2024 16:49
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner October 18, 2024 16:49
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
the links work well!

@ncdiehl11 ncdiehl11 merged commit 46d5ab4 into edge Oct 18, 2024
20 checks passed
@ncdiehl11 ncdiehl11 deleted the pd_fix-privacy-settings-copy branch October 18, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants