refactor(api): Allow adding/removing tips on HW API without await
#16530
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
API.remove_tip()
andOT3API.remove_tip()
non-async. This will help with EXEC-779 by letting us keep the whole auto-fixup process non-async..add_tip()
. This isn't directly helpful to us because we use.cache_tip()
anyway, but it's nice for consistency.Test Plan and Hands on Testing
Review requests
async
?Risk assessment
Low if CI covers everything that calls this.