feat(app): implement system language modal #16507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implements the system language modal that displays on first boot of the desktop app or when the language of the computer running the desktop app changes. closes PLAT-536
brenthagen
requested review from
ncdiehl11
and removed request for
a team and
ncdiehl11
TamarZanzouri
pushed a commit
that referenced
this pull request
Oct 18, 2024
implements the system language modal that displays on first boot of the desktop app or when the language of the computer running the desktop app changes. closes PLAT-536
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
implements the system language modal that displays on first boot of the desktop app or when the language of the computer running the desktop app changes.
closes PLAT-536
Test Plan and Hands on Testing
unit tests for the modal and system language matching to supported locales.
Changelog
Review requests
with localization feature flag on, observe modal on first boot prior to setting app language.
config.jsoncan be edited directly inLibrary/Application Support/Opentrons/config.jsonto check different scenarios.Risk assessment
low