fix(labware-library): fix labware-library css issue #16502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix labware-library css issue close
shlokamin
reviewed
Oct 17, 2024
| @@ -0,0 +1,13 @@ | |||
| export const cssModuleSideEffect = (): any => { | |||
There was a problem hiding this comment.
can we add some comments explaining what we're doing and why, and also maybe links to the github issue for vite? coming back later and understanding why we're doing this will be important. im sure this wont be the last time we have to deal with this 😢
There was a problem hiding this comment.
can we also add the appropriate TS types to this plugin?
There was a problem hiding this comment.
+1 to wanting comments with a link to the vite pr
shlokamin
reviewed
Oct 17, 2024
shlokamin
approved these changes
Oct 17, 2024
TamarZanzouri
pushed a commit
that referenced
this pull request
Oct 18, 2024
* fix(labware-library): fix labware-library css issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
fix labware-library css issue
the issue we are facing came from the following PR.
vitejs/vite#16051
I think ideal fix is to align our css with the PR or convert all css into
styled-components, but the thing is that at this moment we don't have time to do that.other solution would be use vite v5.1.6 since the change is in v5.2.0.
before
after
Test Plan and Hands on Testing
go to and check that the layout is not broken.
http://sandbox.labware.opentrons.com/fix_labware-library-css-bundle-issue/
Changelog
Review requests
Risk assessment
low