Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(opentrons-ai-client): Accordion #16499

Merged
merged 7 commits into from
Oct 21, 2024
Merged

feat(opentrons-ai-client): Accordion #16499

merged 7 commits into from
Oct 21, 2024

Conversation

fbelginetw
Copy link
Collaborator

@fbelginetw fbelginetw commented Oct 16, 2024 •
edited
Loading

Overview

This PR adds an Accordion component that will be consumed by the Create Protocol flow in the new AI Client.

image

Test Plan and Hands on Testing

  • Basic scenarios manually tested
  • Accessibility
  • Unit tests

Changelog

  • Add Opentrons AI Client Accordion component

Review requests

  • Validate if this approach for creating components fits the project structure and best practices,

Risk assessment

  • No risk

@fbelginetw fbelginetw changed the title [Opentrons AI Client][TW] accordion feat: AI Client Accordion Oct 16, 2024
@fbelginetw fbelginetw changed the title feat: AI Client Accordion feat(opentrons-ai-client): Accordion Oct 16, 2024
@fbelginetw fbelginetw requested a review from shlokamin October 17, 2024 15:32
@fbelginetw fbelginetw marked this pull request as ready for review October 17, 2024 15:32
@fbelginetw fbelginetw requested a review from a team as a code owner October 17, 2024 15:32
@fbelginetw
refactor: make container also clickable, update logic to not allow cl…
33bce1c 
…icks when opened or disabled and update sb examples
@fbelginetw fbelginetw requested review from koji, y3rsh and Elyorcv October 18, 2024 15:08
shlokamin
shlokamin approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@shlokamin shlokamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question about why aria-disabled and disabled get assigned different values but nothing blocking!

opentrons-ai-client/src/molecules/Accordion/index.tsx Outdated Show resolved Hide resolved
@fbelginetw fbelginetw merged commit 0fc0db9 into edge Oct 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connected-znaim connected-znaim connected-znaim left review comments

@shlokamin shlokamin shlokamin approved these changes

@koji koji Awaiting requested review from koji

@y3rsh y3rsh Awaiting requested review from y3rsh

@Elyorcv Elyorcv Awaiting requested review from Elyorcv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fbelginetw @shlokamin @connected-znaim @ac-fbelgine