Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol-designer): transfer tools advanced settings and batch edit transfer #16488

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Oct 15, 2024

closes AUTH-870, partially addresses AUTH-926

Overview

This wires up the advanced settings for the transfer tools and the batch edit transfer tools. The modals still need to be updated though: https://opentrons.atlassian.net/browse/AUTH-928

Screenshot 2024-10-15 at 21 44 11 Screenshot 2024-10-15 at 21 44 27

Test Plan and Hands on Testing

Create a protocol and add a transfer steps. look through the tools and make sure the advanced settings works as expected

additionally, test out a multi-dispense (distribute) step where you aspirate 1 well and dispense into more than 1 well, checkout the distribute options in the dispense advanced settings and make sure it works as expected

finally, test out the move liquid batch edit toolbox (command + click on 2 transfer steps to access it)

Note that the modals are not updated yet and most of them are using the old code. there is a followup ticket for those.

Changelog

  • add a bunch new components for the different advanced settings fields in transfer tools. they will be used in the mix tools and batch edit tools as well i believe
  • wires up the new components to be used in transfer tools
  • wires up the move liquid batch edit tools

Risk assessment

low

@jerader jerader requested review from a team as code owners October 15, 2024 17:07
@jerader jerader requested review from TamarZanzouri, koji and ncdiehl11 and removed request for a team and TamarZanzouri October 15, 2024 17:07
@jerader jerader force-pushed the pd_transfer-advanced-settings branch from 79222bf to 5286092 Compare October 15, 2024 17:46
@jerader jerader changed the title feat(protocol-designer): transfer tools advanced settings feat(protocol-designer): transfer tools advanced settings and batch edit transfer Oct 16, 2024
)

// TODO: update the modal
const FlowRateModal =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plan to export this as FlowRateModal?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah i think that can be done in a followup

@ncdiehl11
Copy link
Collaborator

Everything is looking good but looks like you can save the form with mix being checked with empty values for repetitions and volume
Screenshot 2024-10-17 at 11 30 32 AM

Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🤖
It’s up to you how to handle Nick’s feedback. this pr or a following pr

@jerader
Copy link
Collaborator Author

jerader commented Oct 17, 2024

Everything is looking good but looks like you can save the form with mix being checked with empty values for repetitions and volume Screenshot 2024-10-17 at 11 30 32 AM

@ncdiehl11 oof good catch, i think this is old PD behavior. I'll make a follow-up ticket to address it!

@jerader
Copy link
Collaborator Author

jerader commented Oct 17, 2024

the followup ticket: https://opentrons.atlassian.net/browse/AUTH-961

@jerader jerader merged commit 35efa6f into edge Oct 17, 2024
32 checks passed
@jerader jerader deleted the pd_transfer-advanced-settings branch October 17, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants