-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(protocol-designer): transfer tools advanced settings and batch edit transfer #16488
Conversation
79222bf
to
5286092
Compare
...ocol-designer/src/pages/Designer/ProtocolSteps/BatchEditToolbox/BatchEditMoveLiquidTools.tsx
Show resolved
Hide resolved
protocol-designer/src/pages/Designer/ProtocolSteps/BatchEditToolbox/index.tsx
Outdated
Show resolved
Hide resolved
...ol-designer/src/pages/Designer/ProtocolSteps/StepForm/PipetteFields/BlowoutLocationField.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/pages/Designer/ProtocolSteps/StepForm/PipetteFields/DisposalField.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/pages/Designer/ProtocolSteps/StepForm/PipetteFields/FlowRateInput.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/pages/Designer/ProtocolSteps/StepForm/PipetteFields/FlowRateInput.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/pages/Designer/ProtocolSteps/StepForm/PipetteFields/FlowRateInput.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/pages/Designer/ProtocolSteps/StepForm/PipetteFields/FlowRateInput.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/pages/Designer/ProtocolSteps/StepForm/PipetteFields/FlowRateInput.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/pages/Designer/ProtocolSteps/StepForm/PipetteFields/FlowRateInput.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/pages/Designer/ProtocolSteps/StepForm/PipetteFields/FlowRateInput.tsx
Show resolved
Hide resolved
protocol-designer/src/pages/Designer/ProtocolSteps/StepForm/PipetteFields/FlowRateInput.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/pages/Designer/ProtocolSteps/StepForm/PipetteFields/FlowRateInput.tsx
Outdated
Show resolved
Hide resolved
) | ||
|
||
// TODO: update the modal | ||
const FlowRateModal = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plan to export this as FlowRateModal
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah i think that can be done in a followup
protocol-designer/src/pages/Designer/ProtocolSteps/StepForm/PipetteFields/PositionField.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/pages/Designer/ProtocolSteps/StepForm/PipetteFields/PositionField.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/pages/Designer/ProtocolSteps/StepForm/PipetteFields/WellsOrderField.tsx
Outdated
Show resolved
Hide resolved
f047228
to
4660fb6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 🤖
It’s up to you how to handle Nick’s feedback. this pr or a following pr
@ncdiehl11 oof good catch, i think this is old PD behavior. I'll make a follow-up ticket to address it! |
the followup ticket: https://opentrons.atlassian.net/browse/AUTH-961 |
closes AUTH-870, partially addresses AUTH-926
Overview
This wires up the advanced settings for the transfer tools and the batch edit transfer tools. The modals still need to be updated though: https://opentrons.atlassian.net/browse/AUTH-928
Test Plan and Hands on Testing
Create a protocol and add a transfer steps. look through the tools and make sure the advanced settings works as expected
additionally, test out a multi-dispense (distribute) step where you aspirate 1 well and dispense into more than 1 well, checkout the distribute options in the dispense advanced settings and make sure it works as expected
finally, test out the move liquid batch edit toolbox (command + click on 2 transfer steps to access it)
Note that the modals are not updated yet and most of them are using the old code. there is a followup ticket for those.
Changelog
Risk assessment
low