feat(api): Return tipPhysicallyAttachedError
from dropTip
and dropTipInPlace
commands
#16485
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Half of EXEC-764.
Test Plan and Hands on Testing
I've done this:
dropTip
command on a robot. Immediately after the pipette drops the tip, physically hold the tip sensor up, to induce atipPhysicallyAttachedError
.Changelog
This is the main part of EXEC-764. It adds
try
/except
blocks in the implementations ofdropTip
anddropTipInPlace
commands to turn it into a recoverable, defined error when the sensor detects that the tip is still attached.This unfortunately does not totally close EXEC-764 because there is a problem with
opentrons.hardware
's tip tracking getting out of sync withopentrons.protocol_engine
's tip tracking. If you retry the command, the robot will incorrectly act as if there is not a tip on the pipette, and slam the tip into the bottom of the tip rack. This is the same problem that we had withpickUpTip
'stipPhysicallyMissingError
, and we solved it there by adding new hardware API methods that put tip tracking more in control of the caller. I'll do the same thing for these commands in a separate PR.Review requests
errorType
, but I haven't really thought it through. Any thoughts?Risk assessment
Low.