Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): Return tipPhysicallyAttachedError from dropTip and dropTipInPlace commands #16485

Merged
merged 4 commits into from
Oct 16, 2024

Conversation

SyntaxColoring
Copy link
Contributor

Overview

Half of EXEC-764.

Test Plan and Hands on Testing

I've done this:

  1. Run a dropTip command on a robot. Immediately after the pipette drops the tip, physically hold the tip sensor up, to induce a tipPhysicallyAttachedError.
  2. Confirm that the robot enters error recovery mode. Confirm with manual HTTP requests that the error shape looks correct.

Changelog

This is the main part of EXEC-764. It adds try/except blocks in the implementations of dropTip and dropTipInPlace commands to turn it into a recoverable, defined error when the sensor detects that the tip is still attached.

This unfortunately does not totally close EXEC-764 because there is a problem with opentrons.hardware's tip tracking getting out of sync with opentrons.protocol_engine's tip tracking. If you retry the command, the robot will incorrectly act as if there is not a tip on the pipette, and slam the tip into the bottom of the tip rack. This is the same problem that we had with pickUpTip's tipPhysicallyMissingError, and we solved it there by adding new hardware API methods that put tip tracking more in control of the caller. I'll do the same thing for these commands in a separate PR.

Review requests

  • Does the plan above to fix tip tracking sound good?
  • I am not catching stalls or collisions here because that smells like something that we'll want to keep a distinct errorType, but I haven't really thought it through. Any thoughts?

Risk assessment

Low.

@SyntaxColoring SyntaxColoring requested a review from a team October 14, 2024 22:07
@SyntaxColoring SyntaxColoring requested a review from a team as a code owner October 14, 2024 22:07
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, and I agree with keeping stalls separate.

@SyntaxColoring SyntaxColoring merged commit 6645be2 into edge Oct 16, 2024
27 checks passed
@SyntaxColoring SyntaxColoring deleted the drop_tip_defined_error branch October 16, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants