Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(protocol-designer): add Eppendorf to removeOpentronsPhrases #16470

Merged
merged 1 commit into from
Oct 17, 2024
Merged

fix(protocol-designer): add Eppendorf to removeOpentronsPhrases #16470

merged 1 commit into from
Oct 17, 2024

Conversation

koji
Copy link
Contributor

@koji koji commented Oct 11, 2024

Overview

add Eppendorf to removeOpentronsPhrases

after

Screenshot 2024-10-11 at 2 25 22 PM

close RQA-3321

Test Plan and Hands on Testing

  1. select ot-2
  2. single channel pipette + gen1 + 10ul
  3. click show all tips button

Changelog

  • add Eppendorf to removeOpentronsPhrases and add a test

Review requests

low

Risk assessment

@koji
fix(protocol-designer): add Eppendorf to removeOpentronsPhrases
15acdfe 
add Eppendorf to removeOpentronsPhrases

close RQA-3321
@koji koji marked this pull request as ready for review October 11, 2024 18:30
@koji koji requested a review from a team as a code owner October 11, 2024 18:30
@koji koji removed the request for review from a team October 11, 2024 18:35
ncdiehl11
ncdiehl11 approved these changes Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@ncdiehl11 ncdiehl11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It just hit me that maybe we should make this util case insensitive?

@koji
Copy link
Contributor Author

koji commented Oct 11, 2024

Looks good. It just hit me that maybe we should make this util case insensitive?

oh, that is an interesting idea.

@ncdiehl11
Copy link
Collaborator

Looks good. It just hit me that maybe we should make this util case insensitive?

oh, that is an interesting idea.

Can always add on if needed. Not sure if super necessary right now

@koji
Copy link
Contributor Author

koji commented Oct 11, 2024

Looks good. It just hit me that maybe we should make this util case insensitive?

oh, that is an interesting idea.

Can always add on if needed. Not sure if super necessary right now

@ncdiehl11 I will test your idea next week.
The thing is that Skye says, cutting Eppendorf isn't enough 😭
Mel/Felix will give a solution to us.
We'll need to update something, so I'll keep this PR open.

jerader
jerader approved these changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@koji koji merged commit 546e1bf into edge Oct 17, 2024
24 checks passed
TamarZanzouri pushed a commit that referenced this pull request Oct 18, 2024
@koji @TamarZanzouri
fix(protocol-designer): add Eppendorf to removeOpentronsPhrases (#16470)
0b977af 
* fix(protocol-designer): add Eppendorf to removeOpentronsPhrases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerader jerader jerader approved these changes

@ncdiehl11 ncdiehl11 ncdiehl11 approved these changes

@syao1226 syao1226 Awaiting requested review from syao1226

Assignees
No one assigned
Labels
authorship
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@koji @ncdiehl11 @jerader