Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): ai server and client local dev #16452

Merged
merged 5 commits into from
Oct 16, 2024
Merged

Conversation

y3rsh
Copy link
Member

@y3rsh y3rsh commented Oct 9, 2024

Overview

https://opentrons.atlassian.net/browse/AUTH-937
Add documentation to help understand and do development on the ai-server and ai-client.

Risk

Low, documentation and Makefile target consistency.

@y3rsh y3rsh self-assigned this Oct 9, 2024
@y3rsh y3rsh requested a review from a team as a code owner October 9, 2024 23:32
@y3rsh
Copy link
Member Author

y3rsh commented Oct 10, 2024

  • Add the consent flow for Auth0 on localhost

Copy link
Contributor

@Elyorcv Elyorcv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jwwojak jwwojak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe as these are readme files an unsolicited editorial review isn't really needed. However, I saw the (docs) prefix in the PR title in an email and had to look. There are other things you could do here too to make improvements, but I was unable to get to them. Here are some suggestions for consideration.

opentrons-ai-client/README.md Outdated Show resolved Hide resolved
opentrons-ai-client/README.md Outdated Show resolved Hide resolved
opentrons-ai-client/README.md Outdated Show resolved Hide resolved
opentrons-ai-server/README.md Outdated Show resolved Hide resolved
opentrons-ai-server/README.md Outdated Show resolved Hide resolved
opentrons-ai-server/README.md Outdated Show resolved Hide resolved
@y3rsh
Copy link
Member Author

y3rsh commented Oct 16, 2024

@jwwojak Thanks for the great comments. I addressed them all

😊

@y3rsh y3rsh merged commit f88fabb into edge Oct 16, 2024
9 checks passed
@y3rsh y3rsh deleted the ai-server-dev-setup-docs branch October 16, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants