Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ai-server): improved logging #16435

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Conversation

y3rsh
Copy link
Member

@y3rsh y3rsh commented Oct 8, 2024

Overview

Redo logging for this API

Test Plan and Hands on Testing

  • local logging output in the container is JSON
  • local logging output with local environment is text

Once merged and auto-deployed to staging, we will look at the output in DataDog

Risk assessment

  • medium - we are not getting what we need in DataDog to build filters and alerts and so we must evolve with this this
  • there is also a risk with the middleware stacking, so we will test a lot in staging

@y3rsh y3rsh self-assigned this Oct 8, 2024
@y3rsh y3rsh requested review from a team as code owners October 8, 2024 19:05
Copy link
Contributor

@Elyorcv Elyorcv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -39,6 +39,7 @@ def get_auth_headers(self, token_override: str | None = None) -> dict[str, str]:
return {"Authorization": f"Bearer {self.settings.HF_API_KEY}"}

def post_simulate_protocol(self, protocol: Protocol) -> Response:
console.print(self.auth_headers)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit pick: remove?

@y3rsh y3rsh merged commit 9ea27a2 into edge Oct 8, 2024
13 checks passed
@y3rsh y3rsh deleted the ai-server-huggingface-troubleshooting branch October 8, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants